Store multiple invocations of dmesg check for the same test in one file #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
happz
force-pushed
the
dmesg-multiple-reports-sharing-file
branch
from
3bda528 to
96a0bc2
Compare
happz
added
the
status | ready for merge
This should prevent loosing dmesg reports in the case of tests that restart or reboot: all reports except the last one are lost. The filename remains the same, but it's no longer overwritten. `dmesg` check invocations append to it, with proper headers: ``` \## Acquired at 2024-12-03T13:12:23.536502+00:00 [ 0.000000] Linux version 6.11.4-301.fc41.x86_64 (mockbuild@9b6b61418589428cb880a7020233b56f) (gcc (GCC) 14.2.1 20240912 (Red Hat 14.2.1-3), GNU ld version 2.43.1-2.fc41) #1 SMP PREEMPT_DYNAMIC Sun Oct 20 15:02:33 UTC 2024 [ 0.000000] Command line: BOOT_IMAGE=(hd0,gpt3)/vmlinuz-6.11.4-301.fc41.x86_64 no_timer_check console=tty1 console=ttyS0,115200n8 systemd.firstboot=off root=UUID=815e66c2-6a8a-4984-a890-1a3c710bf933 rootflags=subvol=root [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable ... \## Acquired at 2024-12-03T13:12:23.596179+00:00 ... \## Acquired at 2024-12-03T13:12:23.622283+00:00 ... ``` Fixes #3317
psss
force-pushed
the
dmesg-multiple-reports-sharing-file
branch
from
96a0bc2 to
5835873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent loosing dmesg reports in the case of tests that restart or reboot: all reports except the last one are lost.
The filename remains the same, but it's no longer overwritten.
dmesgcheck invocations append to it, with proper headers:Fixes #3317
Pull Request Checklist