Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check if in_const_heap when visiting grey objects #220

Open
tekknolagi opened this issue Jan 1, 2025 · 1 comment · May be fixed by #223
Open

Only check if in_const_heap when visiting grey objects #220

tekknolagi opened this issue Jan 1, 2025 · 1 comment · May be fixed by #223

Comments

@tekknolagi
Copy link
Owner

scrapscript/runtime.c

Line 223 in c48b196

if (in_const_heap(from)) {

We should never have a const object in the heap
@tekknolagi
Copy link
Owner Author

We might have one in the roots though. Unless we prohibit it

tekknolagi added a commit that referenced this issue Jan 1, 2025
@tekknolagi
Don't make const heap objects roots
86cdcf2 
The jury is still out on whether this is faster.

Fix #220
@tekknolagi tekknolagi linked a pull request Jan 1, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't make const heap objects roots tekknolagi/scrapscript
1 participant
@tekknolagi