-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve panic issue in pipeline controller caused by CustomRun #8562
base: main
Are you sure you want to change the base?
fix: resolve panic issue in pipeline controller caused by CustomRun #8562
Conversation
/test check-pr-has-kind-label |
@l-qing: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
fix tektoncd#8561 When validating the optional workspace of the pipeline, encountering a CustomRun should not cause a panic, as this configuration will be validated again during the creation of the CustomRun.
ba28357
to
3c1814d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fix #8561
When validating the optional workspace of the pipeline, encountering a CustomRun should not cause a panic, as this configuration will be validated again during the creation of the CustomRun.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind bug