Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NX for task management #5050

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Use NX for task management #5050

wants to merge 6 commits into from

Conversation

Juveniel
Copy link
Contributor

@Juveniel Juveniel force-pushed the setup-nx branch 3 times, most recently from 6c86839 to de03290 Compare June 20, 2024 13:42
@Juveniel Juveniel self-assigned this Jul 15, 2024
@Juveniel Juveniel added Infrastructure Issues related overall infrastructure for build, test and deployment Enhancement New feature of an existing functionality or an improvement of an existing functionality. labels Sep 4, 2024
@Juveniel Juveniel marked this pull request as ready for review September 4, 2024 12:22
@Juveniel Juveniel requested a review from a team as a code owner September 4, 2024 12:22
@Juveniel Juveniel changed the title Setup nx Use NX for task management Sep 4, 2024
"lint:scripts": "eslint \"**/*.{js,jsx,ts,tsx,mjs}\"",
"lint:styles": "stylelint \"**/*.scss\"",
"lint:staged": "lint-staged --verbose",
"build": "nx run @progress/kendo-themes-html:build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can define short package names by adding a project.json to the respective package folder, e.g.:

packages/html/package.json

{
  "name": "html",
  "$schema": "../../node_modules/nx/schemas/project-schema.json",
  "sourceRoot": "packages/html/src",
  "projectType": "library",
  "tags": []
}

Copy link
Contributor

@zhpenkov zhpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm run docs script fails. (env: Windows)

Edited: This was sass related issue, disregard.

Copy link
Contributor

@zhpenkov zhpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create-screenshots script does not appear to work in this branch, and develop
(env: Windows)

@zhpenkov
Copy link
Contributor

zhpenkov commented Oct 1, 2024

I tested the other scrips and everything looks good, the caching for compiling sass works properly.

Here are some metrics I gathered through this process (env: Windows)

Command nx with cache nx without cache old
npm run sass 3s 49s 1m 15s
npm run sass:flat 2s 32s 48s
npm run sass:swatches 3s 1m 1m 50s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature of an existing functionality or an improvement of an existing functionality. Infrastructure Issues related overall infrastructure for build, test and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants