Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Upgrade ingress-web to use new api version #235

Closed
naormatania opened this issue Oct 19, 2021 · 1 comment
Closed

[Feature Request] Upgrade ingress-web to use new api version #235

naormatania opened this issue Oct 19, 2021 · 1 comment
Labels
enhancement New feature or request PR in review Issue has a PR in-review

Comments

@naormatania
Copy link

Is your feature request related to a problem? Please describe.

According to https://kubernetes.io/blog/2021/07/26/update-with-ingress-nginx/ since kubernetes 1.22 Ingress object won't be accessible from networking.k8s.io/v1beta1 but only through networking.k8s.io/v1.

Running temporal-web with ingress enabled on minikube v1.23.2 (kubernetes v1.22.1) fails for this reason.

Describe the solution you'd like

Check in https://github.com/temporalio/helm-charts/blob/master/templates/web-ingress.yaml if it has api version of networking.k8s.io/v1 and fix yaml accordingly
@naormatania naormatania added the enhancement New feature or request label Oct 19, 2021
@rallinator7 rallinator7 mentioned this issue Mar 1, 2022
Closed
@robholland robholland added the PR in review Issue has a PR in-review label Jun 15, 2024
@robholland
Copy link
Contributor

Fixed by #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request PR in review Issue has a PR in-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robholland @naormatania