Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to setup job annotations (e.g for step-ca) #557

Closed
slavb18 opened this issue Sep 10, 2024 · 1 comment
Closed

Option to setup job annotations (e.g for step-ca) #557

slavb18 opened this issue Sep 10, 2024 · 1 comment

Comments

@slavb18
Copy link

slavb18 commented Sep 10, 2024 •
edited
Loading

When datasource uses TLS authorization, and certificate is generated using step-ca,
I need option to setup annotations, as noted here
This could be done adding

      {{- with $.Values.server.podAnnotations }}
      annotations:
        {{- toYaml . | nindent 8 }}
      {{- end }}

helm-charts/charts/temporal/templates/server-job.yaml

Line 11 in ef7ec10

metadata:

slavb18 added a commit to iconicompany/helm-charts that referenced this issue Sep 10, 2024
@slavb18
add Values.server.podAnnotations or job fixes temporalio#557
6550ad1
@slavb18
Copy link
Author

slavb18 commented Oct 16, 2024

Closing as implemented

schema:
  podAnnotations:
    autocert.step.sm/mode: "0600"

Filed another related bug #595

@slavb18 slavb18 closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slavb18