Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Ability to specify SQL_CONNECT_ATTRIBUTES for temporal-schema job #561

Open
adigiorgi-clickup opened this issue Sep 24, 2024 · 2 comments · May be fixed by #567
Open

[Feature Request] Ability to specify SQL_CONNECT_ATTRIBUTES for temporal-schema job #561

adigiorgi-clickup opened this issue Sep 24, 2024 · 2 comments · May be fixed by #567
Labels
enhancement New feature or request

Comments

@adigiorgi-clickup
Copy link

Is your feature request related to a problem? Please describe.

The temporal-schema job always tries to create tables in the public schema, but our DBAs don't allow the use of the public schema.

By setting the SQL_CONNECT_ATTRIBUTES env var to something like search_path=temporalvisibility, we can actually tell temporal-schema to populate a different schema, but unfortunately the Helm chart doesn't allow to specify SQL_CONNECT_ATTRIBUTES.

Describe the solution you'd like

Allow to specify the SQL_CONNECT_ATTRIBUTES env var for the temporal-schema job in the Helm chart.

Additional context

N/A
@adigiorgi-clickup adigiorgi-clickup added the enhancement New feature or request label Sep 24, 2024
@adigiorgi-clickup
Copy link
Author

If you like the idea, I'd be happy to try and send a PR!

@robholland
Copy link
Contributor

Hey, yes I'd be interested in a PR for this.

@adigiorgi-clickup adigiorgi-clickup linked a pull request Sep 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@robholland @adigiorgi-clickup