Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service account creation when no Values.serviceAccount.name is defined #562

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Fix service account creation when no Values.serviceAccount.name is defined #562

merged 6 commits into from
Oct 3, 2024

Commits on Sep 26, 2024

  1. fix: always create service account and reference its name

    @luong-komorebi
    luong-komorebi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    76eeea7 View commit details
    Browse the repository at this point in the history

  2. fix: remove excessive check that prevents service account from being … 

    …referenced
    @luong-komorebi
    luong-komorebi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7dca0f2 View commit details
    Browse the repository at this point in the history

  3. docs: clarify behaviour with naming service account

    @luong-komorebi
    luong-komorebi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    efe1c53 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. docs: spread service account name into multiple lines 

    Co-authored-by: Rob Holland <[email protected]>
    @luong-komorebi @robholland
    luong-komorebi and robholland authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8c5ce5d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into patch-service-account-name

    @robholland
    robholland committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    689ff5a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into patch-service-account-name

    @robholland
    robholland committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6f15d94 View commit details
    Browse the repository at this point in the history