Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduating (addon2core) and de-graduating (core2addon) policies #686

Closed
bhack opened this issue Nov 8, 2019 · 6 comments · Fixed by #774
Closed

Graduating (addon2core) and de-graduating (core2addon) policies #686

bhack opened this issue Nov 8, 2019 · 6 comments · Fixed by #774

Comments

@bhack
Copy link
Contributor

bhack commented Nov 8, 2019

#550 (comment)

/cc @ewilderj / @seanpmorgan @karmel

@karmel
Copy link
Contributor

karmel commented Nov 8, 2019

The policy thus far has been somewhat adhoc, but the pieces are in place to define a more formal policy. We could say something like, if we want to push something to Keras, submit an RFC to keras-team/governance, and go through the standard review. For pulls from Addons, what would you prefer, @seanpmorgan ? An issue? An RFC?

This won't solve the problem in the linked thread, though, which is that the desire for features manifests in many places. What did you have in mind, @bhack ?

@seanpmorgan
Copy link
Member

seanpmorgan commented Nov 8, 2019

Yeah this is certainly a process that we want to formalize but it's a bit tricky. I like the idea of all Keras migrations going to keras-governance as an RFC. Going forward we'll make that the procedure for Keras migrations.

Do we have thoughts for things that don't fit as Keras API (e.g. some of our image processing functionality?) Is a tensorflow/community RFC too much?

Regarding tracking we've started this process with this document on the root of our repo:
https://github.com/tensorflow/addons/blob/master/MIGRATED_TO_CORE.md

We spoke with some contributors and we think a GitHub project is a better tool to use instead of a static document. Anyone know if we can link keras-goverenance RFCs in that project even though the repo is outside of our organization?

EDIT --- Also as Karmel said... open to suggestions for a way to consolidate requests

@karmel
Copy link
Contributor

karmel commented Nov 8, 2019

A TF RFC (acronym bingo!) for non-Keras things would be great. It doesn't have to be very heavyweight, but I think it's a very good practice to get into.

@ewilderj
Copy link
Contributor

ewilderj commented Nov 8, 2019

RFCs don't have to be long. Would rather we had more than less.
cc/ @theadactyl @joanafilipa

@bhack
Copy link
Contributor Author

bhack commented Nov 8, 2019

Image processing or in general image namespace it Is another confusing topic.
I.e. check tensorflow/graphics#107

I think we need to unify the stuff a little bit if we don't want the newcomers to be confused in a multirepository pinball.

So I'am for unify RFC in TF community repo and relaxing RFC verbosity threshold if it is needed to lowering the overhead.

@bhack
Copy link
Contributor Author

bhack commented Nov 8, 2019

I'am propose to start to put Keras issue in read only mode relatively soon and start, with the community support, to add extra labels for Keras issue bot migration to Tensorflow repo.
We can agree over few extra labels to classify the ticket for the migration mini-bot (ignore, migrable, etc..).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants