Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorflow Serving should handle SIGTERM correctly #1853

Open
miguelvr opened this issue May 2, 2021 · 5 comments
Open

Tensorflow Serving should handle SIGTERM correctly #1853

miguelvr opened this issue May 2, 2021 · 5 comments

Comments

@miguelvr
Copy link

miguelvr commented May 2, 2021

TF Serving should terminate gracefully when SIGTERM is received.

This is especially important for docker / kubernetes use cases when a process is terminated gracefully or is killed have very different meanings for determinating a workload success status.

@arghyaganguly
Copy link
Contributor

Related issues :- #799,#498,#356.

@miguelvr
Copy link
Author

miguelvr commented May 3, 2021

Related issues :- #799,#498,#356.

All closed and unsolved... I looked it up before

@vaskozl
Copy link

vaskozl commented Mar 23, 2023

What kind of server doesn't handle signals, it's basic functionality of any server. I was really surprised to find out that tensorflow-serving just ignores it.

Ideally SIGTERM should do a graceful shut down where all existing connections are served by shutting down.

Otherwise the relevant signal should be set in the Dockerfile.

@sivukhin
Copy link

sivukhin commented Mar 5, 2024

Bumping issue again. Are there any plans to support graceful shutdown for tensorflow-serving? As already been said - for hosting tensorflow_serving in k8s this is must have feature for easy & smooth deployments rollout and scale up/scale down events.

CC @nniuzft

@yutkin
Copy link

yutkin commented Sep 20, 2024

Is there any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants