Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf Drop when redundant code is removed from tt-fabric FVC Producer #16907

Open
ubcheema opened this issue Jan 20, 2025 · 0 comments
Open

Perf Drop when redundant code is removed from tt-fabric FVC Producer #16907

ubcheema opened this issue Jan 20, 2025 · 0 comments
Assignees
Labels

Comments

@ubcheema
Copy link
Contributor

In FVC producer logic, fvc_out_wrptr can be removed as it is redundant.

The one place where it is being used, the value can be calculated as:
local_pull_request->pull_request.wr_ptr = inc_ptr_with_wrap(fvc_out_rdptr, words_available)

However, doing this drops bandwidth by ~14%.
This drop in perf needs to be properly understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants