Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] ... #16922

Open
asandhupatlaTT opened this issue Jan 20, 2025 · 1 comment
Open

[Bug Report] ... #16922

asandhupatlaTT opened this issue Jan 20, 2025 · 1 comment
Labels
bug Something isn't working op_cat: reduces

Comments

@asandhupatlaTT
Copy link
Contributor

asandhupatlaTT commented Jan 20, 2025

Describe the bug
Wrong pcc for argmax

To Reproduce
run any argmax test case. For example:
pytest tests/tt_eager/python_api_testing/sweep_tests/pytests/tt_dnn/test_argmax_int.py::TestArgmax::test_argmax[memconfig0--1-input_shapes1]

Expected behavior
Correct PCC

Additional context
Related to #16479

@asandhupatlaTT asandhupatlaTT added the bug Something isn't working label Jan 20, 2025
@asandhupatlaTT
Copy link
Contributor Author

Adding @TT-BrianLiu since i disabled one of his test case.
Adding @bbradelTT for visibility

Similar issue was seen: #11550 but issue was gone (despite having wrong argmax output dimensions)

i fixed the wrong dim issue at #16479 but i get pcc failures. So, i had to disable few test cases.

Snapshot of failing test case:

Input is torch.Size([1, 1, 10, 20]) & output tensor dim is torch.Size([1, 1, 1, 10]) for dim=-1 . Here, PCC is good & test case passes :

Image

Where as, after my patch which fixes the wrong dims of output, i get wrong PCC but correct output tensor shape

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working op_cat: reduces
Projects
None yet
Development

No branches or pull requests

2 participants