Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collaborate? #1

Closed
jonschlinkert opened this issue Apr 23, 2018 · 3 comments
Closed

collaborate? #1

jonschlinkert opened this issue Apr 23, 2018 · 3 comments

Comments

@jonschlinkert
Copy link

jonschlinkert commented Apr 23, 2018

Thanks for the attribution, it would have been awesome to have these ideas and improvements as contributions is-glob and glob-base.

You write fantastic code, we have an org for globbing stuff so that the entire community can collaborate on making them better. I'd be happy to make you guys members and would love to have your involvement in improving those libs or whatever you're interested in.

edit: I guess I'm also wondering why you are copying the code from those libs into this one, instead of requiring them in? Is it just to reduce a single dependency?

@terkelg
Copy link
Owner

terkelg commented May 3, 2018

Hi @jonschlinkert I'm totally up for that! Thanks for the kind words and all you amazing community work.

It's actually not for the dependencies but because I planned to do more customisation to them - especially look into performance (for tiny-glob). I also find it easier to work in one file than jumping around in different repos. I still plan to experiment and possible deviate further from the original code when I have time.

Let's work together!

@jonschlinkert
Copy link
Author

Great! and thank you as well for the kind words!

I also find it easier to work in one file than jumping around in different repos.

I agree. A few years ago, when I was learning to program I would create a module for whatever I was trying to learn. But lately I've been trying to reduce dependencies as much as possible. This is a good example.

I want to refactor our matching libs to reduce deps and improve performance. I'd love your help if you're interested. I don't have an emotional attachment to any libraries or approaches to doing anything. I just like writing code and collaborating on interesting projects.

@jonschlinkert
Copy link
Author

btw, I created a library very similar to globrex about a year ago but never published it. It's a matching library like micromatch - not just for creating a regex, but it's minimal and has a kind-of-similar parsing approach. maybe I'll push that up for discussion.

@terkelg terkelg closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants