Skip to content
This repository has been archived by the owner on Feb 17, 2024. It is now read-only.

docker image is run by default as root (privileged) user #68

Open
Constantin07 opened this issue Jan 11, 2023 · 3 comments
Open

docker image is run by default as root (privileged) user #68

Constantin07 opened this issue Jan 11, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Constantin07
Copy link

At the moment docker image runs as root user when invoked.
I would suggest to use a non-privileged user in image by default.

@wata727 wata727 added the enhancement New feature or request label Jan 14, 2023
@wata727
Copy link
Member

wata727 commented Jan 14, 2023

You are right. But I'm a little concerned about the incompatibility of changing the default user...

@Constantin07
Copy link
Author

Constantin07 commented Jan 17, 2023

@wata727 here is PR with the change #69 ready for review please.
Technically, inside container it runs as non-privileged user the same way.
Do you have an example of some incompatibility ?
PS: it does make sense to add in feature at least some test scenarios in CI so that we can capture broken tests for build container.

@wata727
Copy link
Member

wata727 commented Jan 21, 2023

For example, the following code from Super-Linter will no longer work.
https://github.com/github/super-linter/blob/05f34c653f433dfac36856d446a0d624c46c2012/Dockerfile#L124

Originally, this image was not intended to be used as-is (probably too many things are missing), so a non-root user may not be necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants