Skip to content

Finish the migration guide? #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexeyr-ci2 opened this issue Apr 29, 2025 · 0 comments
Open

Finish the migration guide? #979

alexeyr-ci2 opened this issue Apr 29, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@alexeyr-ci2
Copy link

Posting under this template since the description includes "missing documentation"

What you did:

Read https://github.com/testing-library/react-hooks-testing-library/blob/chore/migration-guide/MIGRATION_GUIDE.md.

What happened:

https://github.com/testing-library/react-hooks-testing-library/blob/chore/migration-guide/MIGRATION_GUIDE.md ends with the "wrapper Props" header.

Is it supposed to say that initialProps in @testing-library/react-hooks are passed both to the hook and to the wrapper, but in @testing-library/react they are only passed to the hook? I just ran into this issue and took quite a lot of time to figure out that my wrapper didn't get Apollo mocks with the @testing-library/react version of renderHook.

Problem description:

The migration guide is incomplete.

@alexeyr-ci2 alexeyr-ci2 added the bug Something isn't working label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant