Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve merged dataframe api #24

Open
teto opened this issue Jul 1, 2019 · 0 comments
Open

improve merged dataframe api #24

teto opened this issue Jul 1, 2019 · 0 comments

Comments

@teto
Copy link
Owner

teto commented Jul 1, 2019

Merged dataframes are the result of mapping packets from one pcap to packets of another pcap.

Currently, it's a bit hard to know if a dataframe was merged or not.
Also some functions work on single/merged dataframes just assuming columns are named the same. This could easily lead to some issue.

The code should work with SENDER_SUFFIX != "" or refactor to make it clearer the dataframe is a merged one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teto