Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation to oli82/esphome-junctek_khf? #26

Open
hslabbert opened this issue Aug 24, 2024 · 0 comments
Open

Relation to oli82/esphome-junctek_khf? #26

hslabbert opened this issue Aug 24, 2024 · 0 comments

Comments

@hslabbert
Copy link

I see a project at https://github.com/oli82/esphome-junctek_khf that looks like basically a clone/download + re-upload of this project, but then with a chunk of changes added in afterwards (additional sensors etc). I've not had any response there to some recent PRs for fixes, and was wondering about trying to bring some of those improvements back here. Is there a reason that you're aware of for that separate repo? #17 looks like an initial "oops" on them trying to create their own copy.

The license on that repo is still MIT; would you be open to bringing some of those improvements over here, if someone were to take a stab at getting the changes incorporated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant