From 40d844de5b1a0cd0da26685e78995c90d45f7d7a Mon Sep 17 00:00:00 2001 From: Milind Dethe <99114125+milinddethe15@users.noreply.github.com> Date: Sun, 5 Jan 2025 15:28:08 +0530 Subject: [PATCH] receive: unhide tsdb.out-of-order.time-window and tsdb.out-of-order.cap-max (#8032) * Unhide tsdb.out-of-order.time-window and tsdb.out-of-order.cap-max Signed-off-by: milinddethe15 * make docs Signed-off-by: milinddethe15 * make docs Signed-off-by: milinddethe15 --------- Signed-off-by: milinddethe15 --- cmd/thanos/receive.go | 4 ++-- docs/components/receive.md | 12 ++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/cmd/thanos/receive.go b/cmd/thanos/receive.go index e3724d65fe..541d5371a8 100644 --- a/cmd/thanos/receive.go +++ b/cmd/thanos/receive.go @@ -1007,11 +1007,11 @@ func (rc *receiveConfig) registerFlag(cmd extkingpin.FlagClause) { rc.tsdbOutOfOrderTimeWindow = extkingpin.ModelDuration(cmd.Flag("tsdb.out-of-order.time-window", "[EXPERIMENTAL] Configures the allowed time window for ingestion of out-of-order samples. Disabled (0s) by default"+ "Please note if you enable this option and you use compactor, make sure you have the --enable-vertical-compaction flag enabled, otherwise you might risk compactor halt.", - ).Default("0s").Hidden()) + ).Default("0s")) cmd.Flag("tsdb.out-of-order.cap-max", "[EXPERIMENTAL] Configures the maximum capacity for out-of-order chunks (in samples). If set to <=0, default value 32 is assumed.", - ).Default("0").Hidden().Int64Var(&rc.tsdbOutOfOrderCapMax) + ).Default("0").Int64Var(&rc.tsdbOutOfOrderCapMax) cmd.Flag("tsdb.allow-overlapping-blocks", "Allow overlapping blocks, which in turn enables vertical compaction and vertical query merge. Does not do anything, enabled all the time.").Default("false").BoolVar(&rc.tsdbAllowOverlappingBlocks) diff --git a/docs/components/receive.md b/docs/components/receive.md index 536b2d2cdb..73ec0bbf61 100644 --- a/docs/components/receive.md +++ b/docs/components/receive.md @@ -580,6 +580,18 @@ Flags: --tsdb.no-lockfile Do not create lockfile in TSDB data directory. In any case, the lockfiles will be deleted on next startup. + --tsdb.out-of-order.cap-max=0 + [EXPERIMENTAL] Configures the maximum capacity + for out-of-order chunks (in samples). If set to + <=0, default value 32 is assumed. + --tsdb.out-of-order.time-window=0s + [EXPERIMENTAL] Configures the allowed time + window for ingestion of out-of-order samples. + Disabled (0s) by defaultPlease note if you + enable this option and you use compactor, make + sure you have the --enable-vertical-compaction + flag enabled, otherwise you might risk + compactor halt. --tsdb.path="./data" Data directory of TSDB. --tsdb.retention=15d How long to retain raw samples on local storage. 0d - disables the retention