Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a func converting go-kit log to slog #7969

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Add a func converting go-kit log to slog #7969

merged 1 commit into from
Feb 3, 2025

Conversation

SungJin1212
Copy link
Contributor

@SungJin1212 SungJin1212 commented Dec 9, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

This PR adds a function GoKitLogToSlog to convert go-kit/log to slog.
Fixes #7949

Verification

I added a test code to verify the converted slog level should conform to the initial go-kit/log.

@SungJin1212 SungJin1212 force-pushed the Add-GoKitLogToSlog branch 4 times, most recently from 281c11e to 28621c3 Compare December 9, 2024 04:50
yeya24
yeya24 previously approved these changes Dec 14, 2024
View reviewed changes
yeya24
yeya24 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit 57efc2a into thanos-io:main Feb 3, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

@pedro-stanaka pedro-stanaka pedro-stanaka approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace go-kit/log with log/slog
3 participants
@SungJin1212 @pedro-stanaka @yeya24