Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of having a ExtraSmall variant for icon buttons #295

Open
tqwewe opened this issue Nov 8, 2024 · 0 comments
Open

Possibility of having a ExtraSmall variant for icon buttons #295

tqwewe opened this issue Nov 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tqwewe
Copy link
Contributor

tqwewe commented Nov 8, 2024

The smallest variant for a button is ButtonSize::Small, however this icon can be a little big for some uses cases, despite it being the smallest variant.

The icon size when using ButtonSize::Small is 20px, but it can look out of place due to it being a little big. Many button icons, including the ones seen in Github toolbar and grafana dashboard are 16px or 18px.

Example of Github button icons (16px icon size):
Screenshot 2024-11-09 at 1 04 56 am

Example of Grafana button icons (18px icon size):
Screenshot 2024-11-09 at 1 05 21 am

Example of Thaw UI small button icon size (20px icon size) used in a card header which looks a little oversized compared to the text:
Screenshot 2024-11-09 at 1 06 32 am

For additional context, here's the button sizes I observe in the UI libraries mentioned as resources in Thaw's README:

  • Fluent UI - 20px
  • Pigment - couldn't find the exact size, but I see they also have extra small variant, so likely below 20px
  • Naive UI - 18px
@luoxiaozero luoxiaozero added the enhancement New feature or request label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants