Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagPickerOption text prop is required but should be optional #307

Open
tqwewe opened this issue Nov 17, 2024 · 1 comment
Open

TagPickerOption text prop is required but should be optional #307

tqwewe opened this issue Nov 17, 2024 · 1 comment

Comments

@tqwewe
Copy link
Contributor

tqwewe commented Nov 17, 2024

The TagPickerOption's text prop seems to be an alternative to specifying children, however it is a required prop.

What is the purpose of having a text prop here as well as children? It seems redundant.
If children are specified for rendering slightly more advanced content, then the text prop needs to be set to text="" to bypass the compile error due to it being required.

<TagPickerOption value=bookmaker_str text=""> // text="" is required here..
    <Avatar size=22 src="..." />
    {option}
</TagPickerOption>
@tqwewe tqwewe changed the title TagPickerOption text prop is required TagPickerOption text prop is required but should be optional Nov 17, 2024
@luoxiaozero
Copy link
Collaborator

The text prop is used for TagPicker input box search, so it must be specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants