Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting errors installing this package on Python 3.9 on Windows:
To fix this, I deleted the checked-in C file and modified
setup.py
to invoke Cython to build it all from scratch. This relies on setuptools >= 18.0 for proper Cython support. Other than that, I don't believe there are any potentially backwards-incompatible changes. I have not tested this on old versions like 2.7 and 3.2 like the readme mentions.I also fixed the specification of build dependencies. It will now automatically install numpy and cython before installing the package. Furthermore, all dependencies have minimum versions specified in accordance with the readme. Technically, matplotlib should be less than version 3.3.0 since that's when the
warn
kwarg ofmatplotlib.use
was removed. I didn't restrict it to that since there's already a PR open to remove that kwarg anyway (#16).