Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you looking for maintainers here? #452

Closed
OskarStark opened this issue Sep 11, 2024 · 12 comments
Closed

Are you looking for maintainers here? #452

OskarStark opened this issue Sep 11, 2024 · 12 comments

Comments

@OskarStark
Copy link
Collaborator

OskarStark commented Sep 11, 2024

It looks like there is not much activity here, so I would offer my help to maintain this repository.

Cheers, Oskar

cc @mvhirsch @igst @silasjoisten @localheinz @staabm

@silasjoisten
Copy link
Collaborator

I would too.

@shish
Copy link
Collaborator

shish commented Nov 21, 2024

FWIW I have a maintained fork (with nearly all of the PR's here merged, flagged as a drop-in replacement so you only need to update dependencies for the top-level composer.json) at https://github.com/shish/safe

@moufmouf
Copy link
Member

Hey all!

Sorry, @Kharhamel and I have had some hectic schedule. I'm working full time on WorkAdventure and obviously don't have enough time to maintain the project appropriately.

So, YES! we are looking for maintainers.

I'll do my best to put Safe in a correct state for PHP 8.4, but Safe definitely needs some love. @shish I'll probably backport the changes in your fork. Do you want to be added as a maintainer? (@OskarStark, @silasjoisten I would be happy to add you too, shall I do that?)

@OskarStark
Copy link
Collaborator Author

Yes please add both of us (Silas and I are working together)

@moufmouf
Copy link
Member

@OskarStark @silasjoisten Done!
What would be the good way of doing things starting from here? Backporting all @shish changes and then starting merging submitted PRs that are not already part of @shish work?

@silasjoisten
Copy link
Collaborator

Sounds good to me!

@shish
Copy link
Collaborator

shish commented Nov 26, 2024

Yeah I'm happy to be added as a maintainer and avoid fragmentation :)

@OskarStark
Copy link
Collaborator Author

@staabm, what about you?

@staabm
Copy link
Collaborator

staabm commented Nov 26, 2024

sure, why not.

(Please also add us to the phpstan extension repo)

@moufmouf
Copy link
Member

Cool!
@shish @staabm @OskarStark @silasjoisten You have all be added to this repo and the PHPStan extension.

Super happy to have you guys as maintainers. I should have done that way before!

I think the best thing to do for me is to step aside and let you guys merge your respective PRs and tag releases accordingly. You are all experienced maintainers so I won't get in the way! ❤️

@OskarStark
Copy link
Collaborator Author

Thanks for the trust and being open 🖖 community will thank you 🙏

@danepowell
Copy link

When you backport the changes, I'd appreciate if you please don't drop support for PHP 8.1 until it's officially EOL next year 😄

#441 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants