Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set engines in package.json #116

Open
einsteinsfool opened this issue Sep 16, 2024 · 5 comments
Open

Set engines in package.json #116

einsteinsfool opened this issue Sep 16, 2024 · 5 comments

Comments

@einsteinsfool
Copy link

einsteinsfool commented Sep 16, 2024

It would be nice to know which NodeJS versions are supported by fdir.
All that needs to be done is to add the code below to package.json:

  "engines": {
    "node": ">= 16.0.0"
  }

I deduced version 16 based on testing NodeJS on CI here.

@jakebailey
Copy link

Testing of 14 was removed in 3c608bd, but I don't think that actually introduced any new stuff; if the package really does support 14, it would be nice to declare that; mocha's engines are 14+ (as are TSs) so that would be sort of nice to have to replace glob or something.

Understandable if not.

@SuperchupuDev
Copy link
Contributor

i believe that the library intentionally doesn't use newer node features to maintain compatibility, if the engines field is added it should reflect on what versions it works in even if testing on <14 was dropped

@thecodrr
Copy link
Owner

thecodrr commented Sep 26, 2024

If engines is set to v14 then CI must also add tests for node v14 to make sure things remain working and there are no breaking changes.

Update: the tests don't run on node@14. If anyone can make them work on node@14 that'd be good enough to add node 14 to engines.

@SuperchupuDev
Copy link
Contributor

adding an engines field to anything above >=12.0.0 would be a breaking change for tinyglobby users btw, would it be possible to keep engines compatibility with node 12 at least during this major version?

@jakebailey
Copy link

The version of vitest depended on in this repo only supports >=14.18, though I can't even seem to use that as something in the deps uses ||= somewhere.

The tests don't actually use any fancy features of vitest, so something simpler may be usable too, but I don't think this will be super simple. Not even vitest 0.1.0 supported Node 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants