Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embroider: Inject Default theme via <link> in index.html #40

Open
gossi opened this issue Jan 6, 2023 · 0 comments
Open

Embroider: Inject Default theme via <link> in index.html #40

gossi opened this issue Jan 6, 2023 · 0 comments

Comments

@gossi
Copy link
Member

gossi commented Jan 6, 2023

At the moment, the contentFor() hook is used to inject the <link> element for the default theme. The idea is to remove all used hooks over time to opt out of classic build pipeline. To remove the <link> for the default theme, the idea is to tell consumers to inject a <link> tag into their index.html, which could look like so:

<link rel="stylesheet" href="{{theemoDefaultTheme}}">

and {{theemoDefaultTheme}} will be replaced with the proper theme url - see #39

Open Question

Is it possible to provide variables for index.html?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant