Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I would to be able to provide a path to my server entry point (server.js) #12

Open
thescientist13 opened this issue Sep 9, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@thescientist13
Copy link
Member

This would allow any user to provide a custom path to their own server's entry point location.

COPY ./server.js ./

CMD ["babel-node", "--presets=@babel/preset-react,@babel/preset-env", "server.js"]

Default value should be server.js

@thescientist13 thescientist13 added this to the MVP milestone Sep 9, 2018
@thescientist13 thescientist13 self-assigned this Sep 9, 2018
@thescientist13
Copy link
Member Author

thescientist13 commented Sep 9, 2018

It should be emphasized that the location of this file will be relative to the src/ directory in the container as such

app/
  server.js
  src/
  static/

So paths in server.js should take that into consideration, e.g.

import Express from 'express';
import React from 'react';
import { createStore } from 'redux';
import { Provider } from 'react-redux';
import counterApp from './src/reducers'; // this is a path that needs to reference _src/_
import App from './src/containers/App';  // this is a path that needs to reference _src/_
import { renderToString } from 'react-dom/server';
import qs from 'qs';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant