Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I would to be able to run a custom build script to build my app for the server #3

Open
thescientist13 opened this issue Sep 5, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Sep 5, 2018

This would allow any user to build and bootstrap their app using their own npm script.

I think a good way to think about this is as a "hook", so in the Dockerfile it would be something like

# install your project's dependencies, run webpack, etc.  
# Output directory here should should match the first path of the next COPY command
RUN yarn ssr:hook:setup

And in the project's package.json

"scripts": {
  "build": "webpack --progress",
  "ssr:hook:setup": "npm install && npm run build",
}
@thescientist13 thescientist13 added the enhancement New feature or request label Sep 5, 2018
@thescientist13 thescientist13 added this to the POC milestone Sep 5, 2018
@thescientist13 thescientist13 self-assigned this Sep 5, 2018
@thescientist13 thescientist13 modified the milestones: POC, MVP Sep 9, 2018
@thescientist13 thescientist13 changed the title As a user I would to be able to provide a custom build script at startup As a user I would to be able to run a custom build script to prepare my app for SSR Sep 9, 2018
@thescientist13 thescientist13 changed the title As a user I would to be able to run a custom build script to prepare my app for SSR As a user I would to be able to run a custom build script to build my app for the server Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant