Add PHPStan Github Action #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyrfel
reviewed
Feb 5, 2020
|
|
||
|
|
||
| parameters: | ||
| ignoreErrors: |
There was a problem hiding this comment.
@rvanlaak I think it would be better we fixed these errors than ignoring them.
There was a problem hiding this comment.
Absolutely, but it could cause bugs where this PR does focus on adding static analyses to begin with. That way new code will be covered. What about fixing it in a new PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure code quality via Github Actions.
No dependencies added to the project.
Added baseline so current state of the project passes. Remove entries here to start increasing code quality 🚀
References
https://medium.com/@ondrejmirtes/phpstans-baseline-feature-lets-you-hold-new-code-to-a-higher-standard-e77d815a5dff