Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug state for PS/2 real hardware testing with logs #870

Draft
wants to merge 1 commit into
base: theseus_main
Choose a base branch
from

Conversation

hecatia-elegua
Copy link
Contributor

@hecatia-elegua hecatia-elegua commented Mar 6, 2023

  • just prints out debug info to vga
  • should loop on error so you can see logs

Please try this as is and type some stuff, then update keyboard.keyboard_scancode_set(ScancodeSet::Set1)?; to use Set2 and maybe Set 3 as well. Some of these might print bogus scancode errors, I'm interested in seeing "ps2_keyboard_handler" logs.

Then also try putting an infinite loop in device_manager after the ps2 setup (I mean after all the ps2 setup is done, not just the controller), so I can see the debug logs of the setup.

(Of course this is just for testing, the real PR will come later)

@kevinaboos
Copy link
Member

thanks! I have left comments and log files on discord.

In short, it works on my real hw and in QEMU normally! However, it doesn't work in QEMU with KVM enabled (make run host=yes), as that results in the virtual hw being different. So something's still not fully correct.

@hecatia-elegua
Copy link
Contributor Author

I'd love to have automatic test runs on different emulators for making changes to something like this.

@kevinaboos
Copy link
Member

yeah, that'd be great. We could do a qemu test easily, but everything else would be difficult, even kvm. Not sure about other emulators like VirtualBox or VMware.

@kevinaboos
Copy link
Member

Shall we close this now that #884 has been merged in? Or did you want to keep it around for future usage?

@hecatia-elegua
Copy link
Contributor Author

I would like to keep it around, especially for others to test real hardware as well.
Might update it. Even better (and I will try this sometime) would be some feature/build option just for debug, or some more flexibility with respect to logging. Something like the log crate but for choosing in which scope debug/trace is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants