regions_mm: Invalidate cache when freeing memory

A memory region may be allocated to a different core than before, and performing a writeback by the cache may corrupt the current data. Signed-off-by: Adrian Warecki <[email protected]>
thesofproject · Jul 5, 2024 · 36132d4 · 36132d4
1 parent 6f12b80
commit 36132d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/zephyr/lib/alloc.c b/zephyr/lib/alloc.c
@@ -243,6 +243,7 @@ static void virtual_heap_free(void *ptr)
 	ptr = (__sparse_force void *)sys_cache_cached_ptr_get(ptr);
 
 	K_SPINLOCK(&vmh_lock) {
+		virtual_buffers_heap->core_id = cpu_get_id();
 		ret = vmh_free(virtual_buffers_heap, ptr);
 	}
 

diff --git a/zephyr/lib/regions_mm.c b/zephyr/lib/regions_mm.c
@@ -617,8 +617,14 @@ int vmh_free(struct vmh_heap *heap, void *ptr)
 	if (retval)
 		return retval;
 
+	/* Platforms based on xtensa have a non-coherent cache between cores. Before releasing
+	 * a memory block, it is necessary to invalidate the cache. This memory block can be
+	 * allocated to another core and performing cache writeback by the previous owner will
+	 * destroy current content of the main memory. */
+	sys_cache_data_invd_range(ptr, size_to_free);
 	return vmh_unmap_region(heap->physical_blocks_allocators[mem_block_iter], ptr,
 				size_to_free);
+
 }
 
 /**