remove idelay use and move to k_busy_wait in SOF Zephyr code #9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare to remove idelay() use from generic code, so it can be removed from the SOF rtos abstraction layer. Signed-off-by: Kai Vehmanen <[email protected]>
Prepare to remove idelay() use from generic code, so it can be removed from the SOF rtos abstraction layer. Signed-off-by: Kai Vehmanen <[email protected]>
Prepare to remove idelay() use from generic code, so it can be removed from the SOF rtos abstraction layer. This is Zephyr specific code, so k_busy_wait() can be used directly. Signed-off-by: Kai Vehmanen <[email protected]>
Implement wait_delay*() variants with k_busy_wait(). If some target requires to customize the busy wait implementation, this can be done with Zephyr CONFIG_ARCH_HAS_CUSTOM_BUSY_WAIT. Remove idelay() as this is no longer used in generic SOF code. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
requested review from
tmleman,
lyakh,
iuliana-prodan,
dbaluta,
abonislawski,
lgirdwood,
plbossart,
mmaka1 and
lbetlej
as code owners
tmleman
approved these changes
Nov 15, 2024
lyakh
approved these changes
Nov 18, 2024
| #include <rtos/timer.h> | ||
|
|
||
| /* TODO: use equivalent Zephyr */ | ||
| static inline void idelay(int n) | ||
| static inline void wait_delay_us(uint64_t us) |
There was a problem hiding this comment.
nitpick - having this function at the bottom of this patch, where it was before, would both make this patch smaller (probably) and easier to read and keep the grouping of all wait_delay*() functions as now. Not a show-stopper of course, only if you need to update
lgirdwood
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.