Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group / permission editing is not working properly #276

Open
DizzyOnion opened this issue Apr 7, 2015 · 10 comments · May be fixed by #333
Open

Group / permission editing is not working properly #276

DizzyOnion opened this issue Apr 7, 2015 · 10 comments · May be fixed by #333

Comments

@DizzyOnion
Copy link

I recently installed PhotoShow on a small ARM powered server running Debian Squeeze (4.4.5) and PHP 5.3.3 and I'm facing an issue with the group editing / user permissions:
The main user's "root" privilege gets lost after klicking "submit" on the group editing page. Other users permissions (currently 2 in total) get messed up as well. I couldn't figure out what it could be.
The only way to re-enable admin privileges is to edit the accounts.xml directly. All other changes in settings seem to work properly so I doubt it is an issue with file read/write permissions.
@Heather705
Copy link

I had the same result.

@ltguillaume
Copy link

Same here. Furthermore, after putting a user into the uploaders group manually via the xml, I tried to give the group uploaders rights to a certain private folder, but it does not allow them to upload there. I reckon this isn't by design? Or can uploaders only upload to public folders?

@stykoo
Copy link

stykoo commented Jan 16, 2016

Like @ltguillaume I don't understand what the uploaders group is for, or how to give it the right to upload. With my settings only the root users can upload (in both public and private folders).

@nielsswinkels
Copy link

I can confirm this is still an issue. Tested with both firefox and chrome browser.

@gboudreau
Copy link
Contributor

Can you describe in details what you do, and what happens?
I tried to reproduce what is detailed in the initial post, and can't find any problems:

  • I started from the Groups editing page @ /?t=Adm&a=EdA, using the only admin account I have configured.
  • Clicked Submit
  • Conf/accounts.xml didn't change
  • Tried to create a new group; was correctly added to Conf/groups.xml
  • Added my account to the new group; Conf/accounts.xml was modified accordingly.
  • I never lost root access at any point.

@nielsswinkels
Copy link

I had an external person who created an account. Then I created a group. Then I tried to add that person to the group by adding a checkmark for that person in that group, and hit submit. That instead removed the checkmark for my account being root, and didn't make any other changes.

This is from how I remember what I've done. I can retry it tomorrow with a clean install and write down precise steps to reproduce it.

@gboudreau
Copy link
Contributor

Might help. I tried that, and can't reproduce either:

  • enabled registrations
  • created a new account bob
  • using admin account, when in Groups page; bob is part of the user group (default)
  • Create a group testGroup
  • Added bob to that group

@nielsswinkels
Copy link

Now I tried twice with a clean install and I can't reproduce the error there, but on my initial setup it still exists. Weird. I guess I will just reinstall it.

@nielsswinkels
Copy link

It seems that a capital in the username might cause the error.

@gboudreau
Copy link
Contributor

Indeed, I was able to reproduce with BobTest as a username. Will debug with that. Thx

gboudreau added a commit to gboudreau/PhotoShow that referenced this issue Feb 11, 2017
@gboudreau
Bugfix: user with uppercase letters in its username broke the Groups …
56b6a1e 
…page

Fixes thibaud-rohmer#276
@gboudreau gboudreau linked a pull request Feb 11, 2017 that will close this issue
Open
alesc added a commit to alesc/PhotoShow that referenced this issue Feb 28, 2018
@alesc
FIX : user with uppercase letter by gboudreau
c118820 
* Bugfix: user with uppercase letters in its username broke the Groups page

Fixes thibaud-rohmer#276

* Fixing code validation notices in PHPDoc blocks

* Typo in Group::create() method
gboudreau added a commit to gboudreau/PhotoShow that referenced this issue Nov 24, 2018
@gboudreau
Bugfix: user with uppercase letters in its username broke the Groups …
8960725 
…page

Fixes thibaud-rohmer#276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: user with uppercase letters in its username broke the Groups page gboudreau/PhotoShow
6 participants
@gboudreau @ltguillaume @nielsswinkels @DizzyOnion @Heather705 @stykoo