Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow not cycling correctly #353

Open
vletroye opened this issue Nov 1, 2017 · 1 comment
Open

Slideshow not cycling correctly #353

vletroye opened this issue Nov 1, 2017 · 1 comment

Comments

@vletroye
Copy link

vletroye commented Nov 1, 2017

in image_panel.js, when clicking NEXT while being on the last image, PhotoShow is assumed to navigate to the first photo in the linear-pane. And when clicking PREVIOUS while being on the first image, PhotoShow is assumed to navigate to the last photo. But there is a bug IMHO there...

Line 92 should be new_select = $(".linear_panel .item").first();
And line 137 should be new_select = $(".linear_panel .item").last();

Changing these two lines, PhotoShow works as expected. Otherwise, it's stuck respectively on the last/first image...

@vletroye
Copy link
Author

vletroye commented Nov 2, 2017

I did fork the master branch and have create a Pull Request with, among others, that fix: #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant