Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking <a/> tag links in embedded Observable notebooks does nothing #11

Open
metaphorz opened this issue Nov 8, 2021 · 4 comments
Open

Comments

@metaphorz
Copy link

I tried the demo Colab jupyter notebook. Given this cell:

embed('@d3/gallery')

one cannot click on a map type and have an execution. Nothing
happens. Is that intended or is there a workaround?

The cell before that one works fine and allows for interactive control.

@thomasballinger
Copy link
Owner

thomasballinger commented Nov 8, 2021

That's interesting, it looks like these are links (<a href="" /> tags) with relative href destinations. I can't left-click them at all, but I can cmd-click or right-click and "Open Link in New Tab," but since the link is /@d3/animated-treemap that doesn't send me to the right place.

Clicking doing nothing is not intended, I want to understand that better. I wonder if single clicks to localhost are blocked or something? Maybe on Colab (Colab sticks the already-iframed Observable output in another iframe), maybe everywhere?

The part that might be intended, we have to decide, is the link going to the wrong places. Where should a link to /@d3/animated-treemap send users? Maybe it should always be relative to https://observablehq.com, so that this behavior always matches.

@thomasballinger
Copy link
Owner

I think that this embedded notebook and any other Observable documentation notebooks are best viewed at https://observablehq.com and that should be where we sent users generally, so in this case https://observablehq.com/@d3/gallery — but for users' notebooks this is still an important thing to fix.

@metaphorz
Copy link
Author

Thanks. I am positive about observeablehq in general and have used it. I used Processing/JS
for some tests. For the past 6 months, though,
I have been using Google Colab for machine learning work. And, so the idea of a blend of
observable and colab is exciting.

@thomasballinger
Copy link
Owner

That's great to hear, I hope you find this library useful! I think it's a great blend, I like to build a visualization in Observable using data I upload as a File Attachment then swap out that data with live data in a Colab notebook. You can see some examples here: #2

@thomasballinger thomasballinger changed the title demo question Clicking a tag links in Observable notebooks does nothing Nov 28, 2021
@thomasballinger thomasballinger changed the title Clicking a tag links in Observable notebooks does nothing Clicking <a/> tag links in Observable notebooks does nothing Nov 28, 2021
@thomasballinger thomasballinger changed the title Clicking <a/> tag links in Observable notebooks does nothing Clicking <a/> tag links in embedded Observable notebooks does nothing Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants