Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getArticleDirectory allowEmpty not logical #216

Open
thompsonsj opened this issue Oct 28, 2024 · 0 comments
Open

getArticleDirectory allowEmpty not logical #216

thompsonsj opened this issue Oct 28, 2024 · 0 comments

Comments

@thompsonsj
Copy link
Owner

In #215 I noticed that allowEmpty (which is falsey by default) is not consistent with it's name:

payload-crowdin-sync/plugin/src/lib/api/helpers.ts

Line 41 in b56076a

allowEmpty?: boolean,

If allowEmpty is true then an error will be thrown if an article directory is not found.

Consider renaming to disallowEmpty?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thompsonsj