Issue when use DB MS SQL

[herdianabdillah]

Describe the bug
cant insert chinese, japan, thai character in MSSQL, because data type is "varchar"

To Reproduce
Steps to reproduce the behavior:

1. Go to add new FAQ
2. Create a FAQ with chinese, japan or thai character and then save
3. it will become question mark

Expected behavior
able to input that character

phpMyFAQ (please complete the following information):

• phpMyFAQ version 3.0.7
• PHP version 7
• Database : MS SQL
• Elasticsearch no

Additional context
i already fix the issue manually with change data type into "nvarchar" also in the query add N before string

[thorsten]

@herdianabdillah The fix is varchar -> nvarchar?

[herdianabdillah]

@thorsten not only that. in the query also need to add N before the string. in the code should be like this N'%s'

[thorsten]

e.g. INSERT INTO faqdata (col_with_nvarchar) VALUES (N'phpMyFAQ') ?

[thorsten]

Okay, I found some examples on StackOverflow. This is a big change.

[thorsten]

@herdianabdillah What do you think, should I change all VARCHAR() columns to NVARCHAR() or just the ones with user generated content?

[herdianabdillah]

e.g. INSERT INTO faqdata (col_with_nvarchar) VALUES (N'phpMyFAQ') ?

yes, like that

[herdianabdillah]

@herdianabdillah What do you think, should I change all VARCHAR() columns to NVARCHAR() or just the ones with user generated content?

from my case, just the ones with user generated content. like category, faq title, body, keyword, etc. and some case in the user field too for full name so i also change that

[thorsten]

Moving this to the 3.2 milestone as it has a huge impact.