Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in High-Level API and Poe Tasks #1055

Merged

Conversation

opcode81
Copy link
Collaborator

@opcode81 opcode81 commented Feb 14, 2024

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build
  • Add an option to SamplingConfig which allows to configure number of test episodes
  • Make OptimizerFactory more flexible, adding method create_optimizer_for_params
  • Fix AutoAlphaFactoryDefault using hard-coded Adam optimizer
  • Fix mypy issues that were platform/installation-dependent
  • Limit scope of nbqa, resolving issues with files generated by old versions of the build

Fixes #1054

@opcode81 opcode81 added the high-level-api Mainly affects tianshou.highlevel label Feb 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8742e36) 88.18% compared to head (eeb2081) 88.18%.

Files Patch % Lines
tianshou/highlevel/optim.py 90.00% 1 Missing ⚠️
tianshou/highlevel/params/alpha.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1055   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         100      100           
  Lines        8160     8170   +10     
=======================================
+ Hits         7196     7205    +9     
- Misses        964      965    +1     
Flag Coverage Δ
unittests 88.18% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opcode81 opcode81 marked this pull request as ready for review February 14, 2024 19:23
allows the creation of an optimizer given arbitrary parameters
(rather than a module)
@opcode81 opcode81 changed the title Allow to configure number of test episodes in high-level API Improvements in High-Level API Feb 14, 2024
@opcode81 opcode81 requested a review from MischaPanch February 15, 2024 09:23
@opcode81
Copy link
Collaborator Author

Recommend to merge without squashing.

@opcode81 opcode81 changed the title Improvements in High-Level API Improvements in High-Level API and Poe Tasks Feb 15, 2024
@MischaPanch
Copy link
Collaborator

The windows CI job fails b/c you changed pyproject and something about caching fails. I'll delete the current github caches before merging to master, that should fix it

@MischaPanch MischaPanch merged commit 9b6cb69 into thu-ml:master Feb 15, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-level-api Mainly affects tianshou.highlevel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow number of episodes per test step to be configured in high-level API
3 participants