Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to validate a FrameRepr #14

Open
thvdveld opened this issue Mar 13, 2024 · 1 comment
Open

Add a way to validate a FrameRepr #14

thvdveld opened this issue Mar 13, 2024 · 1 comment
Labels
feature New feature or request optimization Something can be optimized

Comments

@thvdveld
Copy link
Owner

The values of a FrameRepr can be anything right now. We try to prevent this by providing a FrameBuilder. However, the fields of FrameRepr are public, meaning an invalid representation can still be constructed. I don't like to make these fields private, since then we need to implement getters for the fields and this would make the API clumsy.

We could however add a validate function to FrameRepr that returns an error when an invalid frame is constructed.
@thvdveld thvdveld added optimization Something can be optimized feature New feature or request labels Mar 13, 2024
@thvdveld
Copy link
Owner Author

Started in 066649a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request optimization Something can be optimized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thvdveld