Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 2c6d162

Browse files
authoredAug 6, 2024··
TDD prep: fix GHA with new dials interface (#117)
* re`document()` with new roxygen * transition to new dials interface in tests * propose a `min_n` less prone to overfit
1 parent 5e9d49e commit 2c6d162

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed
 

‎DESCRIPTION

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Depends:
2222
tune (>= 1.2.0)
2323
Imports:
2424
cli,
25-
dials (>= 0.1.0),
25+
dials (>= 0.3.0),
2626
dplyr (>= 1.1.1),
2727
ggplot2,
2828
parsnip (>= 1.1.0),
@@ -54,4 +54,4 @@ Config/testthat/edition: 3
5454
Encoding: UTF-8
5555
Language: en-US
5656
Roxygen: list(markdown = TRUE)
57-
RoxygenNote: 7.3.1
57+
RoxygenNote: 7.3.2

‎tests/testthat/test-sa-overall.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ test_that("incompatible parameter objects", {
138138

139139
set.seed(1)
140140
grid_with_bigger_range <-
141-
dials::grid_latin_hypercube(dials::mtry(range = c(1, 16)))
141+
dials::grid_space_filling(dials::mtry(range = c(1, 16)))
142142

143143
set.seed(1)
144144
car_folds <- rsample::vfold_cv(car_prices, v = 2)

‎tests/testthat/test-win-loss-overall.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ test_that("one player is really bad", {
7777
add_formula(y ~ .) %>%
7878
add_model(rf_spec)
7979

80-
grid <- tibble(min_n = c(1, 400))
80+
grid <- tibble(min_n = c(1, 40))
8181
ctrl <- control_race(burn_in = 2, alpha = .05, randomize = TRUE)
8282
set.seed(3355)
8383
tuning_results <- tune_race_win_loss(

0 commit comments

Comments
 (0)
Please sign in to comment.