Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contr_one_hot() is also in hardhat but not exported #1215

Open
topepo opened this issue Oct 23, 2024 · 0 comments
Open

contr_one_hot() is also in hardhat but not exported #1215

topepo opened this issue Oct 23, 2024 · 0 comments

Comments

@topepo
Copy link
Member

topepo commented Oct 23, 2024

          `contr_one_hot()` is also in parsnip (where it is exported). 

There are tests there that are a bit more extensive: https://github.com/tidymodels/parsnip/blob/main/tests/testthat/test-contr_one_hot.R

You can bring those over here and I'll open a parsnip issue about the duplication. hardhat would have to export this function for parsnip to use it.

Originally posted by @topepo in tidymodels/hardhat#268 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant