Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designing S3 generics for extensibility #112

Open
hadley opened this issue Apr 28, 2020 · 1 comment
Open

Designing S3 generics for extensibility #112

hadley opened this issue Apr 28, 2020 · 1 comment
Labels

Comments

@hadley
Copy link
Member

hadley commented Apr 28, 2020

As long as the generic contains ..., R CMD check does not compare the method and generic args. See https://github.com/hadley/s3method for sample package that verifies that.

And R CMD check code (via @jimhester): https://github.com/wch/r-source/blob/7345bdb64fc8f6e30dff7077372137bd0e43fb27/src/library/tools/R/QC.R#L2430-L2434

@DavisVaughan
Copy link
Member

This is not entirely true, see https://github.com/DavisVaughan/methodtest for a counterpoint where ... is in the generic and we still get a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants