Changes to quiet mode #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not to be merged until |
jcheng5
force-pushed
the
quiet-tweaks
branch
from
5cc68b4 to
1611241
Compare
jcheng5
force-pushed
the
quiet-tweaks
branch
from
1611241 to
8f42a51
Compare
hadley
approved these changes
Sep 10, 2024
| @@ -14,7 +14,9 @@ NULL | |||
| #' not supply this directly, but instead set the `OPENAI_API_KEY` environment | |||
| #' variable. | |||
| #' @param model The model to use for the chat; defaults to GPT-4o mini. | |||
| #' @param quiet If `TRUE` does not print output as its received. | |||
| #' @param echo If `TRUE`, the `chat()` method streams the response to stdout by | |||
There was a problem hiding this comment.
Since it only affects chat() it seems weird to make it a class property to me.
There was a problem hiding this comment.
I thought so too at first, but for interactive uses (the only place where this will be useful) it seemed annoying to have to remember to do echo=TRUE every time?
There was a problem hiding this comment.
But I don't feel strongly--happy to take it out if you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quiet = TRUEtoecho = FALSEecho = FALSE(i.e. quiet by default)stream,chat_async, andstream_asyncnever echo