Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fortify() for models #6193

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to advance #3816.

It deprecates the fortify() methods for statistical models in favour of broom::tidy() and broom::augment().
Examples now use broom outputs in plots, which requires adding broom to 'Suggests'.
Also the fortify.lm() examples have been condensed, because I couldn't figure out what they were showing aside from variable names.

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@teunbrand
Copy link
Collaborator Author

Thank you for the review!

@teunbrand teunbrand merged commit 3d67907 into tidyverse:main Nov 26, 2024
13 checks passed
@teunbrand teunbrand deleted the fortify_models branch November 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants