Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vectorised replacement failures #551

Open
6 tasks
hadley opened this issue Jul 16, 2024 · 1 comment
Open
6 tasks

Fix vectorised replacement failures #551

hadley opened this issue Jul 16, 2024 · 1 comment
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day upkeep maintenance, infrastructure, and similar

Comments

@hadley hadley added tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day upkeep maintenance, infrastructure, and similar labels Jul 16, 2024
@hadley
Copy link
Member Author

hadley commented Jul 16, 2024

This might be a fun challenge if you're very familiar with the package development process — you need install the dev version of string, fork each package, use pak::pak() to load all dependencies, then run tests/R CMD check, and fixes the revealed bugs in str_replace_all(). Previously the functions were passed a single function and now they're passed a character vector, so you'll need to figure out how to vectorise the existing code.

@hadley hadley changed the title Fixed vectorised replacement failures Fix vectorised replacement failures Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

1 participant