Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unchop() error for incompatible ptype #1478

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

mgirlich
Copy link
Contributor

Fixes #1477

@DavisVaughan
Copy link
Member

Out of curiosity I did a little research into why we didn't already have this in place. I think its because:

#1340 is when we added error_call to df_unchop() in October 2022

But list_unchop() didn't get error_call and error_arg until around the same time, Sept 2022 and Oct 2022 respectively
r-lib/vctrs#1691
r-lib/vctrs#1712

So those args probably didn't exist in list_unchop() at the time, but they do now!

@DavisVaughan DavisVaughan merged commit 454a4c8 into tidyverse:main Aug 28, 2024
14 checks passed
@DavisVaughan
Copy link
Member

Thanks @mgirlich!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message for incompatible ptype unnest()
2 participants