Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standalone files + standardize snapshot tests #1579

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Update standalone files + standardize snapshot tests #1579

merged 11 commits into from
Oct 25, 2024

Commits on Oct 23, 2024

  1. Use recent standalone files

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6d1547a View commit details
    Browse the repository at this point in the history

  2. Recent standalone don't accept integers

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d0661c9 View commit details
    Browse the repository at this point in the history

  3. Use regular snapshot tests. Avoid nesting expect_error()

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6e6beab View commit details
    Browse the repository at this point in the history

  4. Standardize snapshot tests. and use cnd_class = TRUE if `expect_err… 

    …or()` was used.

Put cnd_class on the first line to make it easy to remove it as needed.
    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bd624cd View commit details
    Browse the repository at this point in the history

  5. tidyselect 1.2.1

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    414ae42 View commit details
    Browse the repository at this point in the history

  6. Add workaround for old R snapshot failure

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bdd5a9f View commit details
    Browse the repository at this point in the history

  7. avoid snapshot for this test since it changes slightly across R versions

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c2f994c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. remove cnd_class = TRUE

    @olivroy
    olivroy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b49c272 View commit details
    Browse the repository at this point in the history

  2. Separate snapshot tests for errors.

    @olivroy
    olivroy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    632045a View commit details
    Browse the repository at this point in the history

  3. Update corresponding snapshots

    @olivroy
    olivroy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9e3c8a0 View commit details
    Browse the repository at this point in the history

  4. Merged upstream/main into stand

    @olivroy
    olivroy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b47ac9e View commit details
    Browse the repository at this point in the history