Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standalone files + standardize snapshot tests #1579

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Update standalone files + standardize snapshot tests #1579

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6d1547a
Use recent standalone files
olivroy Oct 23, 2024
d0661c9
Recent standalone don't accept integers
olivroy Oct 23, 2024
6e6beab
Use regular snapshot tests. Avoid nesting `expect_error()`
olivroy Oct 23, 2024
bd624cd
Standardize snapshot tests. and use `cnd_class = TRUE` if `expect_err…
olivroy Oct 23, 2024
414ae42
tidyselect 1.2.1
olivroy Oct 23, 2024
bdd5a9f
Add workaround for old R snapshot failure
olivroy Oct 23, 2024
c2f994c
avoid snapshot for this test since it changes slightly across R versions
olivroy Oct 23, 2024
b49c272
remove cnd_class = TRUE
olivroy Oct 24, 2024
632045a
Separate snapshot tests for errors.
olivroy Oct 24, 2024
9e3c8a0
Update corresponding snapshots
olivroy Oct 24, 2024
b47ac9e
Merged upstream/main into stand
olivroy Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tests/testthat/_snaps/gather.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,9 @@

# gather throws error for weird objects

Code
gather(d, key, val, -x)
Condition <simpleError>
Error:
! object 'd' not found
Code
gather(df, key, val, -y)
Condition <simpleError>
Condition
Error:
! All columns be atomic vectors or lists (not expression)

Expand Down
10 changes: 4 additions & 6 deletions tests/testthat/test-gather.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,11 @@ test_that("gather throws error for weird objects", {
df <- data.frame(y = 1)
df$x <- expression(x)

expect_snapshot(error = TRUE, cnd_class = TRUE, {
gather(d, key, val, -x)
# Can't use snapshot, it changes between versions of R
expect_error(gather(d, key, val, -x), "not found")
olivroy marked this conversation as resolved.
Show resolved Hide resolved
expect_snapshot(error = TRUE, {
gather(df, key, val, -y)
},
# Failing for old versions of R. (<4.3)
transform = function(x) gsub(" in `gather()`", "", x)
)
})

e <- new.env(parent = emptyenv())
e$x <- 1
Expand Down
Loading