From 2d153917ea7048220720c3ed1b52d6306cc0f34b Mon Sep 17 00:00:00 2001 From: Axel Date: Sat, 5 Mar 2016 01:40:38 -0430 Subject: [PATCH 1/2] highlighter.deserialize() callback function highlighter.deserialize() can take a while when having multiple highlights so giving feedback when all the highlights are loaded into the DOM is important. --- src/modules/rangy-highlighter.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/rangy-highlighter.js b/src/modules/rangy-highlighter.js index 4527d5d6..37984b84 100644 --- a/src/modules/rangy-highlighter.js +++ b/src/modules/rangy-highlighter.js @@ -549,7 +549,7 @@ rangy.createModule("Highlighter", ["ClassApplier"], function(api, module) { return serializedHighlights.join("|"); }, - deserialize: function(serialized) { + deserialize: function(serialized, cb) { var serializedHighlights = serialized.split("|"); var highlights = []; @@ -594,6 +594,7 @@ rangy.createModule("Highlighter", ["ClassApplier"], function(api, module) { highlights.push(highlight); } this.highlights = highlights; + typeof cb === 'function' && cb(); } }; From 14a5fad3e4b8afafde5bd239b0934f4705a33242 Mon Sep 17 00:00:00 2001 From: Axel Date: Sat, 5 Mar 2016 02:10:56 -0430 Subject: [PATCH 2/2] Changes added to lib/rangy-highlighter.js --- lib/rangy-highlighter.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/rangy-highlighter.js b/lib/rangy-highlighter.js index bde6ba43..6ec4a276 100644 --- a/lib/rangy-highlighter.js +++ b/lib/rangy-highlighter.js @@ -560,7 +560,7 @@ return serializedHighlights.join("|"); }, - deserialize: function(serialized) { + deserialize: function(serialized, cb) { var serializedHighlights = serialized.split("|"); var highlights = []; @@ -605,6 +605,7 @@ highlights.push(highlight); } this.highlights = highlights; + typeof cb === 'function' && cb(); } };