feat: maxRetryDelay option to limit retryBackoff #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilofuchs
commented
Dec 12, 2024
| expire_seconds = COALESCE($6, expire_seconds), | ||
| retention_minutes = COALESCE($7, retention_minutes), | ||
| dead_letter = COALESCE($8, dead_letter), | ||
| max_retry_delay = $6, |
There was a problem hiding this comment.
It was necessary not to use COALESCE because the user may want to set it to null explicitly
| ELSE now() + ( | ||
| ELSE now() + | ||
| LEAST( | ||
| ( | ||
| retry_delay * 2 ^ LEAST(16, retry_count + 1) / 2 + |
There was a problem hiding this comment.
This 16 limit is not documented, perhaps it should be removed in favour of max_retry_delay in the future?
| CASE | ||
| WHEN COALESCE(j.retry_backoff, q.retry_backoff, retry_backoff_default, false) | ||
| THEN COALESCE(j.max_retry_delay, q.max_retry_delay, max_retry_delay_default) | ||
| ELSE NULL |
There was a problem hiding this comment.
When retry_backoff is not true, we force the max delay to NULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #520
Implements a new flag in
new PgBoss(),queueandjobThis flag limits the exponential backoff to the desired delay, in seconds.
I decided to only apply its value if
retryBackoffis true.Alternatives:
maxRetryBackoffDelaymaxRetryDelayshould also limitretryDelay, but that seems redundantObservations:
updateQueue, with an undefined parameter (maybe use explicit null in this case?)