Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use <time> tag for datetime #156

Open
scarf005 opened this issue Feb 25, 2025 · 1 comment
Open

use <time> tag for datetime #156

scarf005 opened this issue Feb 25, 2025 · 1 comment

Comments

@scarf005
Copy link

scarf005 commented Feb 25, 2025

Adding <time> tag helps with accessibility, such as screen readers.

one thing i'm worried about is that it'll cause breaking changes:

  • add_spans should be renamed to wrap_tags to not be misreading (as span != time)
  • css rules targetting old spans would be broken (span.git-revision-date-localized-plugin)

I'm willing to open a PR if these changes would be acceptable.

@timvink
Copy link
Owner

timvink commented Mar 3, 2025

Sounds good!

add_spans should be renamed to wrap_tags to not be misreading (as span != time)

Let's not introduce any potentially breaking changes. Just add a comment in the code if you think it's unclear for any (future) developers. The code is anything but clean tbh, but it's stable and a small package, so no need to refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants